Page MenuHomePhabricator

Backport all changes related to checkqueue.h and its test from Core
ClosedPublic

Authored by deadalnix on Sep 12 2018, 12:18.

Details

Summary

As per title. Backporting one by one did not seems realitic on that one.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 12 2018, 12:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 12:18
schancel requested changes to this revision.Sep 15 2018, 15:11
schancel added a subscriber: schancel.
schancel added inline comments.
src/checkqueue.h
155 ↗(On Diff #4891)

Can you explain why this changed? Why swap instead of move?

This revision now requires changes to proceed.Sep 15 2018, 15:11
schancel accepted this revision.Sep 18 2018, 01:02
This revision is now accepted and ready to land.Sep 18 2018, 01:02
schancel added inline comments.Sep 18 2018, 01:03
src/checkqueue.h
154 ↗(On Diff #4924)

Seems you were the one responsible for changing this to std::move() in the first place in this commit:

https://reviews.bitcoinabc.org/D297

deadalnix added inline comments.Sep 18 2018, 03:16
src/checkqueue.h
154 ↗(On Diff #4924)

You are correct, std::move seems like a better option here.

This revision was automatically updated to reflect the committed changes.