Page MenuHomePhabricator
Differential D1771

Backport all changes related to checkqueue.h and its test from Core
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 12:18.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING1406dd76d92b: Backport all changes related to checkqueue.h and its test from Core
rABC1406dd76d92b: Backport all changes related to checkqueue.h and its test from Core
Summary

As per title. Backporting one by one did not seems realitic on that one.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr9497
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3301
Build 4686: Bitcoin ABC Buildbot (legacy)
Build 4685: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2018, 12:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 12:18
teamcity added a subscriber: teamcity.Sep 12 2018, 12:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 12 2018, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3278: Diff 4891!Sep 12 2018, 12:55
schancel requested changes to this revision.Sep 15 2018, 15:11
schancel added a subscriber: schancel.
schancel added inline comments.
src/checkqueue.h
155 ↗(On Diff #4891)

Can you explain why this changed? Why swap instead of move?

This revision now requires changes to proceed.Sep 15 2018, 15:11
deadalnix updated this revision to Diff 4924.Sep 15 2018, 17:27

rebase

teamcity added a comment.Sep 15 2018, 18:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 15 2018, 19:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3301: Diff 4924.Sep 15 2018, 19:00
schancel accepted this revision.Sep 18 2018, 01:02
This revision is now accepted and ready to land.Sep 18 2018, 01:02
schancel added inline comments.Sep 18 2018, 01:03
src/checkqueue.h
154

Seems you were the one responsible for changing this to std::move() in the first place in this commit:

https://reviews.bitcoinabc.org/D297

deadalnix added inline comments.Sep 18 2018, 03:16
src/checkqueue.h
154

You are correct, std::move seems like a better option here.

deadalnix updated this revision to Diff 4959.Sep 18 2018, 04:06

rebase

Closed by commit rABC1406dd76d92b: Backport all changes related to checkqueue.h and its test from Core (authored by Jeremy Rubin <jeremy.l.rubin@gmail.com>, committed by deadalnix). · Explain WhySep 18 2018, 04:07
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Sep 18 2018, 04:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 18 2018, 04:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3321: Diff 4959.Sep 18 2018, 04:44
Fabien mentioned this in D2918: test: Plug memory leaks and stack-use-after-scope.May 5 2019, 08:00
markblundeberg added a subscriber: markblundeberg.May 8 2019, 03:33

@deadalnix Presumably this is based on PR9497 https://github.com/bitcoin/bitcoin/pull/9497 ?

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30

Revision Contents
Changeset List

PathSize
src/
1 line
61 lines
test/
1 line
423 lines

Diff 4924

View Options

src/Makefile.test.include

Loading...
View Options

src/checkqueue.h

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...