Merge #13163: Make it clear which functions that are intended to be translation unit local (test/uint256_tests.cpp)
AbandonedPublic
Actions

Authored by nakihito on Jul 2 2019, 21:48.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (test/uint256_tests.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13163-uint256tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6639
Build 11325: Bitcoin ABC Buildbot (legacy)
Build 11324: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 2 2019, 21:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6639: Diff 9936.Jul 2 2019, 21:54

nakihito planned changes to this revision.Jul 2 2019, 22:07

nakihito abandoned this revision.Jul 2 2019, 22:23

Revision Contents
Changeset List

Path

Size

src/

test/

uint256_tests.cpp

2 lines

Diff 9936

View Options

src/test/uint256_tests.cpp

Merge #13163: Make it clear which functions that are intended to be translation unit local (test/uint256_tests.cpp)AbandonedPublicActions