HomePhabricator

Merge #13163: Make it clear which functions that are intended to be translation…

Description

Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files)

Summary:
c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (wallet/rpcdump.cpp, wallet/rpcwallet.cpp, and wallet/walletdb.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up of D3293.

Test Plan:

make check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox, deadalnix, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3510

Details

Provenance
nakihitoAuthored on Jul 2 2019, 00:30
nakihitoPushed on Jul 2 2019, 17:29
Reviewer
Restricted Owners Package
Differential Revision
D3510: Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files)
Parents
rSTAGINGd671f783a0f2: Fix typos
Branches
Unknown
Tags
Unknown