Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files)
ClosedPublic
Actions

Authored by nakihito on Jul 2 2019, 00:34.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation…
rABCe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation…

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (wallet/rpcdump.cpp, wallet/rpcwallet.cpp, and wallet/walletdb.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up of D3293.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 2 2019, 00:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito planned changes to this revision.Jul 2 2019, 00:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6611: Diff 9894.Jul 2 2019, 00:45

deadalnix accepted this revision.Jul 2 2019, 00:54

nakihito requested review of this revision.Jul 2 2019, 01:29

nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet) to Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files).

nakihito edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jul 2 2019, 01:29

nakihito edited the summary of this revision. (Show Details)Jul 2 2019, 01:31

Closed by commit rABCe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation… (authored by nakihito). · Explain WhyJul 2 2019, 17:18

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation….

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jul 2 2019, 23:49

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGe8149e5398f7: Merge #13163: Make it clear which functions that are intended to be translation….Sep 19 2019, 00:51