Page MenuHomePhabricator

Make printchunk() in support/lockedpool.cpp static
ClosedPublic

Authored by nakihito on Jul 2 2019, 19:10.

Details

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (support/lockedpool.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jul 2 2019, 19:10
nakihito planned changes to this revision.Jul 2 2019, 22:07
nakihito edited the summary of this revision. (Show Details)
nakihito requested review of this revision.Jul 2 2019, 22:24
deadalnix requested changes to this revision.Jul 3 2019, 13:15

This is definitively not a merge of 13163 like the title imply. This makes for completely incomprehensible history.

This revision now requires changes to proceed.Jul 3 2019, 13:15
nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (support/lockedpool.cpp) to Make printchunk() in support/lockedpool.cpp static.Jul 3 2019, 22:12
nakihito requested review of this revision.Jul 5 2019, 17:57

Changed title to better describe changes as requested by @deadalnix.

Fabien accepted this revision.Jul 5 2019, 20:57
deadalnix accepted this revision.Jul 6 2019, 14:34
This revision is now accepted and ready to land.Jul 6 2019, 14:34