Make printchunk() in support/lockedpool.cpp static
ClosedPublic
Actions

Authored by nakihito on Jul 2 2019, 19:10.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa6e7748423d6: Make printchunk() in support/lockedpool.cpp static
rABCa6e7748423d6: Make printchunk() in support/lockedpool.cpp static

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (support/lockedpool.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13163-lockedpool

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6633
Build 11313: Bitcoin ABC Buildbot (legacy)
Build 11312: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 2 2019, 19:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6633: Diff 9924.Jul 2 2019, 19:16

nakihito planned changes to this revision.Jul 2 2019, 22:07

nakihito edited the summary of this revision. (Show Details)

nakihito requested review of this revision.Jul 2 2019, 22:24

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jul 2 2019, 23:49

This is definitively not a merge of 13163 like the title imply. This makes for completely incomprehensible history.

This revision now requires changes to proceed.Jul 3 2019, 13:15

deadalnix mentioned this in D3530: Make various functions in src/test/ static.Jul 3 2019, 18:26

nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (support/lockedpool.cpp) to Make printchunk() in support/lockedpool.cpp static.Jul 3 2019, 22:12

Changed title to better describe changes as requested by @deadalnix.

Fabien accepted this revision.Jul 5 2019, 20:57

deadalnix accepted this revision.Jul 6 2019, 14:34

This revision is now accepted and ready to land.Jul 6 2019, 14:34

Closed by commit rABCa6e7748423d6: Make printchunk() in support/lockedpool.cpp static (authored by nakihito). · Explain WhyJul 8 2019, 16:36

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCa6e7748423d6: Make printchunk() in support/lockedpool.cpp static.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa6e7748423d6: Make printchunk() in support/lockedpool.cpp static.Sep 19 2019, 01:04