Page MenuHomePhabricator

Make various functions in src/test/ static
ClosedPublic

Authored by nakihito on Jul 2 2019, 22:27.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCbefd21523dc6: Make various functions in src/test/ static
Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (src/test/)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jul 2 2019, 22:27
nakihito planned changes to this revision.Jul 2 2019, 22:28
nakihito updated this revision to Diff 9938.Jul 2 2019, 22:42

Reverted accidental variable type changes.

markblundeberg edited the summary of this revision. (Show Details)Jul 2 2019, 22:59
deadalnix accepted this revision.Jul 3 2019, 13:09
This revision is now accepted and ready to land.Jul 3 2019, 13:09
deadalnix requested changes to this revision.Jul 3 2019, 18:26

See D3526

This revision now requires changes to proceed.Jul 3 2019, 18:26
nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (src/test/) to Make various functions in src/test/ static.Jul 3 2019, 22:27
nakihito requested review of this revision.Jul 5 2019, 17:56

Changed title to better describe changes as requested by @deadalnix.

Fabien accepted this revision.Jul 5 2019, 21:13
deadalnix accepted this revision.Jul 6 2019, 15:13
This revision is now accepted and ready to land.Jul 6 2019, 15:13
nakihito updated this revision to Diff 10096.Jul 8 2019, 16:27

Rebased due to some file names being changed in a different patch.