static
ClosedPublic
Actions

Authored by nakihito on Jul 2 2019, 22:27.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGbefd21523dc6: Make various functions in src/test/ static
rABCbefd21523dc6: Make various functions in src/test/ static

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (src/test/)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 2 2019, 22:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito planned changes to this revision.Jul 2 2019, 22:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6640: Diff 9937.Jul 2 2019, 22:34

Reverted accidental variable type changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6641: Diff 9938.Jul 2 2019, 22:49

markblundeberg edited the summary of this revision. (Show Details)Jul 2 2019, 22:59

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jul 2 2019, 23:49

deadalnix accepted this revision.Jul 3 2019, 13:09

This revision is now accepted and ready to land.Jul 3 2019, 13:09

See D3526

This revision now requires changes to proceed.Jul 3 2019, 18:26

nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (src/test/) to Make various functions in src/test/ static.Jul 3 2019, 22:27

Changed title to better describe changes as requested by @deadalnix.

Fabien accepted this revision.Jul 5 2019, 21:13

deadalnix accepted this revision.Jul 6 2019, 15:13

This revision is now accepted and ready to land.Jul 6 2019, 15:13

Rebased due to some file names being changed in a different patch.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6734: Diff 10096.Jul 8 2019, 16:36

Closed by commit rABCbefd21523dc6: Make various functions in src/test/ static (authored by nakihito). · Explain WhyJul 8 2019, 19:04

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCbefd21523dc6: Make various functions in src/test/ static.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGbefd21523dc6: Make various functions in src/test/ static.Sep 19 2019, 01:04