Page MenuHomePhabricator
Differential D3061

Update prevector
ClosedPublic
Actions

Authored by deadalnix on May 16 2019, 22:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9c76f4564b0b: Update prevector
rABC9c76f4564b0b: Update prevector
Summary
  • Backport Core PR14266 : Use initializer instead of initializing fields explicitely in every constructors.
  • Backport Core PR14715
  • Backport Core PR13711
  • Backport Core PR14031
  • Backport Core PR14651
Test Plan

Run unit tests with ubsan enabled.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 16 2019, 22:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2019, 22:32
teamcity added a comment.May 16 2019, 22:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5876: Diff 8704.May 16 2019, 22:47
teamcity added a comment.May 16 2019, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.May 17 2019, 18:36
Fabien added a subscriber: Fabien.

You forgot to include the removal in compat.h, that would break the build with gcc 4.x.
Also you can add PR14651 and PR14031 to the list of backports included in this diff.

src/bench/prevector.cpp
48 ↗(On Diff #8704)

Remove

This revision now requires changes to proceed.May 17 2019, 18:36
deadalnix added a comment.May 17 2019, 19:11

GCC4.x doesn't do C++14

deadalnix updated this revision to Diff 8719.May 17 2019, 19:19

Rebase and remove empty line.

teamcity added a comment.May 17 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5887: Diff 8719.May 17 2019, 19:34
teamcity added a comment.May 17 2019, 19:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix updated this revision to Diff 8818.May 23 2019, 12:12

rebase, ping

teamcity added a comment.May 23 2019, 12:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5950: Diff 8818.May 23 2019, 12:27
teamcity added a comment.May 23 2019, 12:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.May 24 2019, 06:45

GCC4.x doesn't do C++14 That's a good point. So I guess the special case targeting it specifically can be removed ?

The initializers changes should be in their own diff.

Please add PR14651 and PR14031 in the summary for reference.

src/bench/prevector.cpp
18 ↗(On Diff #8818)

This block is moved from compat.h in the PR, but here it is duplicated.

This revision now requires changes to proceed.May 24 2019, 06:45
deadalnix updated this revision to Diff 8850.May 24 2019, 14:27

Remove IS_TRIVIALLY_CONSTRUCTIBLE from compat.h

teamcity added a comment.May 24 2019, 14:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 8851.May 24 2019, 14:36

Remove include as well.

teamcity added a comment.May 24 2019, 14:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2019, 14:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5970: Diff 8850.May 24 2019, 14:41
teamcity added a comment.May 24 2019, 14:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5971: Diff 8851.May 24 2019, 14:51
Fabien accepted this revision.May 27 2019, 14:34

From offline discussion: the Use initializer instead of initializing fields explicitely in every constructors. is from PR14266

This revision is now accepted and ready to land.May 27 2019, 14:34
Fabien edited the summary of this revision. (Show Details)May 27 2019, 14:44
Closed by commit rABC9c76f4564b0b: Update prevector (authored by deadalnix). · Explain WhyMay 27 2019, 14:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC9c76f4564b0b: Update prevector.
nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30
deadalnix added a commit: rSTAGING9c76f4564b0b: Update prevector.Sep 18 2019, 23:48

Revision Contents
Changeset List

PathSize
src/
bench/
43 lines
10 lines
43 lines

Diff 8916

View Options

src/bench/prevector.cpp

Loading...
View Options

src/compat.h

Loading...
View Options

src/prevector.h

Loading...