- Backport Core PR14266 : Use initializer instead of initializing fields explicitely in every constructors.
- Backport Core PR14715
- Backport Core PR13711
- Backport Core PR14031
- Backport Core PR14651
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING9c76f4564b0b: Update prevector
rABC9c76f4564b0b: Update prevector
Run unit tests with ubsan enabled.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- prevecrefac
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5950 Build 9960: Bitcoin ABC Buildbot (legacy) Build 9959: arc lint + arc unit
Event Timeline
Comment Actions
You forgot to include the removal in compat.h, that would break the build with gcc 4.x.
Also you can add PR14651 and PR14031 to the list of backports included in this diff.
| src/bench/prevector.cpp | ||
|---|---|---|
| 48 ↗ | (On Diff #8704) | Remove |
Comment Actions
GCC4.x doesn't do C++14 That's a good point. So I guess the special case targeting it specifically can be removed ?
The initializers changes should be in their own diff.
Please add PR14651 and PR14031 in the summary for reference.
| src/bench/prevector.cpp | ||
|---|---|---|
| 18 | This block is moved from compat.h in the PR, but here it is duplicated. | |
Comment Actions
From offline discussion: the Use initializer instead of initializing fields explicitely in every constructors. is from PR14266