Page MenuHomePhabricator

Merge #13291: test: Don't include torcontrol.cpp into the test file
AbandonedPublic

Authored by nakihito on Jun 11 2019, 22:41.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

97c112d4ca Declare TorReply parsing functions in torcontrol_tests (Ben Woosley)

Pull request description:

These methods are standalone string parsing methods which were included
into test via an include of torcontrol.cpp, which is bad practice.

~~Splitting them out reveals that they were the only torcontrol.cpp
methods under test, so the test file is renamed tor_reply_tests.cpp.~~

Introduced in #10408

Tree-SHA512: 8ff11a9c900a88f910a73dfe16f43581a567e9d60e9298a8a963fc9dd7cffb4d97a644da677610aafb7d89f1dd1cede9afeae2c6344305e021a9a322dbcea0ac

Backport of Core PR13291
https://github.com/bitcoin/bitcoin/pull/13291/

Depends on D3293

Should be landed immediately after dependency

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13291
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6273
Build 10593: Bitcoin ABC Teamcity Staging
Build 10592: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 11 2019, 22:41
Owners added a reviewer: Restricted Owners Package.Jun 11 2019, 22:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 22:41
nakihito planned changes to this revision.Jun 11 2019, 22:41
nakihito abandoned this revision.Jun 12 2019, 00:41

Merged with D3283.