Page MenuHomePhabricator

Remove much of the remaining BIP9 code
ClosedPublic

Authored by schancel on Apr 7 2019, 06:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC36fb94ee0821: Remove much of the remaining BIP9 code
Summary

Much of the BIP9 handling code was removed in the following revisions:

This commit removes the unused versionbits handling code, and remaining extern references.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Apr 7 2019, 06:35
Owners added a reviewer: Restricted Owners Package.Apr 7 2019, 06:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2019, 06:35
schancel updated this revision to Diff 7982.Apr 7 2019, 06:37

Fix missing newline

deadalnix added inline comments.Apr 8 2019, 20:00
src/validation.h
16 ↗(On Diff #7982)

Why is that required ? Can't this be replaced favorably by a forward declaration ?

schancel updated this revision to Diff 8004.Apr 9 2019, 01:24

Remove chain.h as an include from validation.h

deadalnix accepted this revision.Apr 9 2019, 14:55
This revision is now accepted and ready to land.Apr 9 2019, 14:55
This revision was automatically updated to reflect the committed changes.