Page MenuHomePhabricator

Remove bip9 version bits warning
ClosedPublic

Authored by deadalnix on Jul 4 2018, 13:51.

Details

Summary

As per title.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix retitled this revision from Remove version bits warning to Remove bip9 version bits warning.Jul 4 2018, 15:30
jasonbcox added inline comments.
test/functional/timing.json
4 ↗(On Diff #4201)

Are these changes supposed to be part of this diff?

test/functional/timing.json
4 ↗(On Diff #4201)

Yes, this file is out of date.

test/functional/timing.json
4 ↗(On Diff #4201)

Right, but why do they belong with bip9 changes?

This revision is now accepted and ready to land.Jul 5 2018, 14:53
test/functional/timing.json
4 ↗(On Diff #4201)

Agree here, but not the end of the world... Just makes cherry-picking weird if needed by anyone else.

This revision was automatically updated to reflect the committed changes.