Page MenuHomePhabricator

Merge #10464: Introduce static DoWarning (simplify UpdateTip)
ClosedPublic

Authored by nakihito on Jun 6 2019, 00:52.

Details

Summary

f28514576 Introduce static DoWarning (simplify UpdateTip) (Jorge Timón)

Tree-SHA512: 58b39f00bc921d47d199ef1cc15e9e36f918ec86e9182de46dc2f24fa9474853a92b18d330a274a3ea7c9b001681fdfa3d86aa2bbebb5c92ac8c5a6f7690dfc1

Backport of Core PR10464
https://github.com/bitcoin/bitcoin/pull/10464/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jun 6 2019, 00:52
Owners added a reviewer: Restricted Owners Package.Jun 6 2019, 00:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 00:52

Note: other usage site was already removed in D1539.

src/validation.cpp
2160 ↗(On Diff #9184)

Also backport the translation change to this warning?

markblundeberg requested changes to this revision.Jun 6 2019, 04:46
This revision now requires changes to proceed.Jun 6 2019, 04:46
nakihito updated this revision to Diff 9190.Jun 6 2019, 17:42

Rebased and added translation change to warning.

jasonbcox accepted this revision.Jun 6 2019, 17:49
markblundeberg accepted this revision.Jun 6 2019, 18:52
This revision is now accepted and ready to land.Jun 6 2019, 18:52