Differential D1539

Remove bip9 version bits warning
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2018, 13:51.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING2ce09798548b: Remove bip9 version bits warning
rABC2ce09798548b: Remove bip9 version bits warning

Summary

As per title.

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

verisonbitwarning

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2799
Build 3708: Bitcoin ABC Buildbot (legacy)
Build 3707: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2018, 13:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2018, 13:51

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2799: Diff 4201.Jul 4 2018, 14:26

deadalnix retitled this revision from Remove version bits warning to Remove bip9 version bits warning.Jul 4 2018, 15:30

jasonbcox added a subscriber: jasonbcox.Jul 4 2018, 15:31

jasonbcox added inline comments.

test/functional/timing.json
4	Are these changes supposed to be part of this diff?

deadalnix added inline comments.Jul 4 2018, 15:33

test/functional/timing.json
4	Yes, this file is out of date.

jasonbcox added inline comments.Jul 4 2018, 15:58

test/functional/timing.json
4	Right, but why do they belong with bip9 changes?

schancel accepted this revision.Jul 5 2018, 14:53

This revision is now accepted and ready to land.Jul 5 2018, 14:53

schancel added inline comments.Jul 5 2018, 14:54

test/functional/timing.json
4	Agree here, but not the end of the world... Just makes cherry-picking weird if needed by anyone else.

Closed by commit rABC2ce09798548b: Remove bip9 version bits warning (authored by deadalnix). · Explain WhyJul 5 2018, 20:49

This revision was automatically updated to reflect the committed changes.

markblundeberg mentioned this in D3231: Remove unused DoWarning function.Jun 6 2019, 04:42

markblundeberg mentioned this in D3230: Merge #10464: Introduce static DoWarning (simplify UpdateTip).Jun 6 2019, 04:44

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCce4e304800ac: Remove unused DoWarning function.Jun 13 2019, 01:42

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGce4e304800ac: Remove unused DoWarning function.Sep 19 2019, 00:15

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinstrings.cpp

2 lines

locale/

6 lines

6 lines

6 lines

5 lines

6 lines

6 lines

6 lines

4 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

4 lines

6 lines

6 lines

63 lines

test/

functional/

p2p-versionbits-warning.py

timing.json

162 lines

Diff 4201

View Options

src/qt/bitcoinstrings.cpp

View Options

src/qt/locale/bitcoin_cs.ts

View Options

src/qt/locale/bitcoin_da.ts

View Options

src/qt/locale/bitcoin_de.ts

View Options

src/qt/locale/bitcoin_en.ts

View Options

src/qt/locale/bitcoin_en_GB.ts

View Options

src/qt/locale/bitcoin_es.ts

View Options

src/qt/locale/bitcoin_es_ES.ts

View Options

src/qt/locale/bitcoin_fa.ts

View Options

src/qt/locale/bitcoin_fr.ts

View Options

src/qt/locale/bitcoin_it.ts

View Options

src/qt/locale/bitcoin_ja.ts

View Options

src/qt/locale/bitcoin_ko_KR.ts

View Options

src/qt/locale/bitcoin_nl.ts

View Options

src/qt/locale/bitcoin_pt_BR.ts

View Options

src/qt/locale/bitcoin_pt_PT.ts

View Options

src/qt/locale/bitcoin_ru.ts

View Options

src/qt/locale/bitcoin_sv.ts

View Options

src/qt/locale/bitcoin_tr.ts

View Options

src/qt/locale/bitcoin_zh_CN.ts

View Options

src/qt/locale/bitcoin_zh_TW.ts

View Options

src/validation.cpp

View Options

test/functional/p2p-versionbits-warning.py

View Options

test/functional/timing.json

Remove bip9 version bits warningClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4201

src/qt/bitcoinstrings.cpp

src/qt/locale/bitcoin_cs.ts

src/qt/locale/bitcoin_da.ts

src/qt/locale/bitcoin_de.ts

src/qt/locale/bitcoin_en.ts

src/qt/locale/bitcoin_en_GB.ts

src/qt/locale/bitcoin_es.ts

src/qt/locale/bitcoin_es_ES.ts

src/qt/locale/bitcoin_fa.ts

src/qt/locale/bitcoin_fr.ts

src/qt/locale/bitcoin_it.ts

src/qt/locale/bitcoin_ja.ts

src/qt/locale/bitcoin_ko_KR.ts

src/qt/locale/bitcoin_nl.ts

src/qt/locale/bitcoin_pt_BR.ts

src/qt/locale/bitcoin_pt_PT.ts

src/qt/locale/bitcoin_ru.ts

src/qt/locale/bitcoin_sv.ts

src/qt/locale/bitcoin_tr.ts

src/qt/locale/bitcoin_zh_CN.ts

src/qt/locale/bitcoin_zh_TW.ts

src/validation.cpp

test/functional/p2p-versionbits-warning.py

test/functional/timing.json

Remove bip9 version bits warning
ClosedPublic
Actions

Revision Contents
Changeset List