Page MenuHomePhabricator

Remove much of the remaining BIP9 code
ClosedPublic

Authored by schancel on Apr 7 2019, 06:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code
rABC36fb94ee0821: Remove much of the remaining BIP9 code
Summary

Much of the BIP9 handling code was removed in the following revisions:

This commit removes the unused versionbits handling code, and remaining extern references.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
del-versionbits (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5419
Build 8900: Bitcoin ABC Buildbot (legacy)
Build 8899: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 7 2019, 06:35
src/validation.h
16 ↗(On Diff #7982)

Why is that required ? Can't this be replaced favorably by a forward declaration ?

Remove chain.h as an include from validation.h

This revision is now accepted and ready to land.Apr 9 2019, 14:55
This revision was automatically updated to reflect the committed changes.