Page MenuHomePhabricator
Differential D1863

Various nits in net.cpp
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2018, 13:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING10b883fc4b73: Various nits in net.cpp
rABC10b883fc4b73: Various nits in net.cpp
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 2 2018, 13:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2018, 13:19
teamcity added a subscriber: teamcity.Oct 2 2018, 13:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3481: Diff 5227!Oct 2 2018, 13:40
teamcity added a comment.Oct 2 2018, 13:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix updated this revision to Diff 5229.Oct 2 2018, 14:14

Remove return from RemoveLocal as it always return the same thing.

teamcity added a comment.Oct 2 2018, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 2 2018, 14:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3483: Diff 5229!Oct 2 2018, 14:36
deadalnix updated this revision to Diff 5243.Oct 3 2018, 12:54

Fix a faulty cast

teamcity added a comment.Oct 3 2018, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 3 2018, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3491: Diff 5243!Oct 3 2018, 13:15
deadalnix updated this revision to Diff 5246.Oct 3 2018, 14:07

A few extra nits

teamcity added a comment.Oct 3 2018, 14:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 3 2018, 14:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3492: Diff 5246!Oct 3 2018, 14:27
deadalnix updated this revision to Diff 5253.Oct 3 2018, 18:16

Make GetnScore static

teamcity added a comment.Oct 3 2018, 18:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 5255.Oct 3 2018, 18:27

One more static cast

teamcity added a comment.Oct 3 2018, 18:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 3 2018, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3499: Diff 5253!Oct 3 2018, 18:37
deadalnix updated this revision to Diff 5256.Oct 3 2018, 18:44

Fix static casts

teamcity added a comment.Oct 3 2018, 18:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 3 2018, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3501: Diff 5255!Oct 3 2018, 18:48
teamcity added a comment.Oct 3 2018, 19:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3502: Diff 5256!Oct 3 2018, 19:03
deadalnix updated this revision to Diff 5263.Oct 4 2018, 09:39

rebase

teamcity added a comment.Oct 4 2018, 09:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 4 2018, 09:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3504: Diff 5263.Oct 4 2018, 09:56
deadalnix updated this revision to Diff 5274.Oct 4 2018, 21:28

rebase

teamcity added a comment.Oct 4 2018, 21:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3511: Diff 5274.Oct 4 2018, 21:46
teamcity added a comment.Oct 4 2018, 21:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1881: Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding.Oct 5 2018, 10:28
deadalnix updated this revision to Diff 5284.Oct 5 2018, 11:41

More nits

teamcity added a comment.Oct 5 2018, 11:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 5 2018, 12:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3517: Diff 5284.Oct 5 2018, 12:00
deadalnix added a child revision: D1886: Remove unused code.Oct 5 2018, 12:46
jasonbcox accepted this revision.Oct 5 2018, 20:17
This revision is now accepted and ready to land.Oct 5 2018, 20:17
Closed by commit rABC10b883fc4b73: Various nits in net.cpp (authored by deadalnix). · Explain WhyOct 6 2018, 09:25
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30

Revision Contents
Changeset List

PathSize
src/
2 lines
77 lines

Diff 5299

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...