Page MenuHomePhabricator

Limit the number of IPs we use from each DNS seeder

Authored by deadalnix on Oct 5 2018, 12:07.



A risk exists where a malicious DNS seeder eclipses a node by returning an enormous number of IP addresses. In this commit we mitigate this risk by limiting the number of IP addresses addrman learns to 256 per DNS seeder.

This is a backprot of core PR12626

Depends on D1881

Test Plan
make check

Start a node, see it connects to the network as expected.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Oct 5 2018, 12:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 12:07
schancel accepted this revision.Oct 5 2018, 22:08
This revision is now accepted and ready to land.Oct 5 2018, 22:08
This revision was automatically updated to reflect the committed changes.