Page MenuHomePhabricator

Limit the number of IPs we use from each DNS seeder
ClosedPublic

Authored by deadalnix on Oct 5 2018, 12:07.

Details

Summary

A risk exists where a malicious DNS seeder eclipses a node by returning an enormous number of IP addresses. In this commit we mitigate this risk by limiting the number of IP addresses addrman learns to 256 per DNS seeder.

This is a backprot of core PR12626

Depends on D1881

Test Plan
make check

Start a node, see it connects to the network as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
limitseederips
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3541
Build 5158: Bitcoin ABC Buildbot (legacy)
Build 5157: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 5 2018, 22:08
This revision was automatically updated to reflect the committed changes.