Page MenuHomePhabricator
Differential D1670

Split test for fee rate and amount
ClosedPublic
Actions

Authored by deadalnix on Aug 24 2018, 12:12.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING89dcfe5dd16d: Split test for fee rate and amount
rABC89dcfe5dd16d: Split test for fee rate and amount
Summary

They are really different thing with different features.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cfreeratetestsplit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3112
Build 4311: Bitcoin ABC Buildbot (legacy)
Build 4310: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 24 2018, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2018, 12:12
teamcity added a subscriber: teamcity.Aug 24 2018, 12:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4632.Aug 24 2018, 12:18

Add the test to cmake

teamcity added a comment.Aug 24 2018, 12:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 24 2018, 12:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3112: Diff 4631.Aug 24 2018, 12:51
teamcity added a comment.Aug 24 2018, 12:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3113: Diff 4632.Aug 24 2018, 12:55
deadalnix added a child revision: D1672: Remove the Amount::GetSatoshi function.Aug 24 2018, 12:59
schancel accepted this revision.Aug 24 2018, 18:54
This revision is now accepted and ready to land.Aug 24 2018, 18:54
schancel mentioned this in D1662: Use ceiling division for fees when funding transactions.Aug 24 2018, 19:01
Closed by commit rABC89dcfe5dd16d: Split test for fee rate and amount (authored by deadalnix). · Explain WhyAug 24 2018, 19:26
This revision was automatically updated to reflect the committed changes.
schancel added a child revision: D1662: Use ceiling division for fees when funding transactions.Aug 24 2018, 19:38
schancel mentioned this in D1815: Fix fee estimate rounding errors.Sep 27 2018, 00:07
schancel mentioned this in rABC8e279dbc14ff: Fix fee estimate rounding errors.Sep 27 2018, 23:39
schancel mentioned this in rSTAGING8e279dbc14ff: Fix fee estimate rounding errors.Oct 9 2018, 20:57

Revision Contents
Changeset List

PathSize
src/
1 line
test/
60 lines
feerate_tests.cpp
amount_tests.cpp
91 lines

Diff 4631

View Options

src/Makefile.test.include

Loading...
View Options

src/test/amount_tests.cpp

Loading...
View Options

src/test/feerate_tests.cpp

Loading...