Page MenuHomePhabricator
Differential D15735

cuckoocache: Return approximate memory size
ClosedPublic
Actions

Authored by PiRK on Mar 19 2024, 12:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7b417a053e6f: cuckoocache: Return approximate memory size
Summary

Returning the approximate total size eliminates the need for
InitS*Cache() to do nElems*sizeof(uint256). The cuckoocache has a better
idea of this information.

This is a partial backport of core#25527
https://github.com/bitcoin/bitcoin/pull/25527/commits/08dbc6ef72db48168dc03991f5f838dae42c8dfd

Depends on D15734

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 19 2024, 12:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2024, 12:32
PiRK requested review of this revision.Mar 19 2024, 12:32
teamcity edited the summary of this revision. (Show Details)Mar 19 2024, 12:32
PiRK updated this revision to Diff 46301.Mar 19 2024, 12:37

split the error log for InitSignatureCache and InitScriptExecutionCache (in Bitcoin ABC they are deifferent args)

PiRK added a child revision: D15736: validationcaches: Abolish arbitrary limit.Mar 19 2024, 12:39
Harbormaster completed remote builds in B27940: Diff 46300.Mar 19 2024, 13:14
Fabien accepted this revision.Mar 19 2024, 13:15
This revision is now accepted and ready to land.Mar 19 2024, 13:15
Harbormaster completed remote builds in B27941: Diff 46301.Mar 19 2024, 13:28
PiRK mentioned this in D15738: validationcaches: Add and use ValidationCacheSizes.Mar 19 2024, 14:13
Closed by commit rABC7b417a053e6f: cuckoocache: Return approximate memory size (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 19 2024, 16:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7b417a053e6f: cuckoocache: Return approximate memory size.

Revision Contents
Changeset List

PathSize
src/
4 lines
15 lines
13 lines
script/
2 lines
10 lines
2 lines
14 lines
test/
util/
4 lines

Diff 46312

View Options

src/bitcoin-chainstate.cpp

Loading...
View Options

src/cuckoocache.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/script/scriptcache.h

Loading...
View Options

src/script/scriptcache.cpp

Loading...
View Options

src/script/sigcache.h

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...