Page MenuHomePhabricator
Differential D15772

[Cashtab] Better error handling for rendering txs
ClosedPublic
Actions

Authored by bytesofman on Mar 24 2024, 12:58.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC1d37abee4859: [Cashtab] Better error handling for rendering txs
Summary

Now that we are in in-node chronik, tokenEntries will always be an array. However, some users got this error when Cashtab migrated to in-node chronik, since parsedTxHistory loaded from storage does not have tokenEntries (coming from nng chronik).

Add better validation to handle this migration case.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
migrate-history-better
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28023
Build 55591: Build Diffcashtab-tests
Build 55590: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 24 2024, 12:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2024, 12:58
bytesofman published this revision for review.Mar 24 2024, 12:58
Harbormaster completed remote builds in B28022: Diff 46416.Mar 24 2024, 13:02
emack requested changes to this revision.Mar 24 2024, 13:27
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/components/Home/Tx.js
586–587 ↗(On Diff #46416)

This type check is redundant because Array.isArray() on an undefined data.tokenEntries will correctly return false.

This revision now requires changes to proceed.Mar 24 2024, 13:27
bytesofman updated this revision to Diff 46419.Mar 24 2024, 13:58

remove redundant type check

Harbormaster completed remote builds in B28023: Diff 46419.Mar 24 2024, 14:05
emack accepted this revision.Mar 24 2024, 23:28
This revision is now accepted and ready to land.Mar 24 2024, 23:28
Closed by commit rABC1d37abee4859: [Cashtab] Better error handling for rendering txs (authored by bytesofman). · Explain WhyMar 25 2024, 01:37
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1d37abee4859: [Cashtab] Better error handling for rendering txs.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Home/
3 lines

Diff 46419

View Options

cashtab/src/components/Home/Tx.js

Loading...