Page MenuHomePhabricator
Differential D15755

Remove ::IsStandardTx(tx, reason) alias
ClosedPublic
Actions

Authored by PiRK on Mar 21 2024, 16:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2692dad01c14: Remove ::IsStandardTx(tx, reason) alias
Summary

Apart from tests, it is only used in one place, so there is no need for
an alias.

This is a partial backport of core#25648
https://github.com/bitcoin/bitcoin/pull/25648/commits/fa8a7f01fe1b6db98097021276ed5d929faadbec

Depends on D15754

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 21 2024, 16:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2024, 16:09
PiRK requested review of this revision.Mar 21 2024, 16:09
teamcity edited the summary of this revision. (Show Details)Mar 21 2024, 16:09
PiRK added a child revision: D15756: Remove ::dustRelayFee global.Mar 21 2024, 16:11
PiRK planned changes to this revision.Mar 21 2024, 16:31

this was meant to be a draft for now, like the rest of the stack

Harbormaster completed remote builds in B27973: Diff 46354.Mar 21 2024, 16:49
PiRK updated this revision to Diff 46386.Mar 22 2024, 16:06

rebase

PiRK added a child revision: D15757: Remove ::fIsBareMultisigStd global.Mar 22 2024, 16:07
Harbormaster completed remote builds in B27995: Diff 46386.Mar 22 2024, 16:44
Fabien accepted this revision.Mar 25 2024, 09:55
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/transaction_tests.cpp
45–46 ↗(On Diff #46386)
This revision is now accepted and ready to land.Mar 25 2024, 09:55
PiRK added inline comments.Mar 25 2024, 12:31
src/test/transaction_tests.cpp
45–46 ↗(On Diff #46386)

They are mutated later in the test.

Closed by commit rABC2692dad01c14: Remove ::IsStandardTx(tx, reason) alias (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 25 2024, 13:44
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2692dad01c14: Remove ::IsStandardTx(tx, reason) alias.

Revision Contents
Changeset List

PathSize
src/
policy/
4 lines
test/
fuzz/
1 line
5 lines
81 lines
3 lines

Diff 46448

View Options

src/policy/settings.h

Loading...
View Options

src/test/fuzz/transaction.cpp

Loading...
View Options

src/test/script_p2sh_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...