Page MenuHomePhabricator
Differential D15753

Remove ::minRelayTxFee global
ClosedPublic
Actions

Authored by PiRK on Mar 21 2024, 16:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1f260dda7638: Remove ::minRelayTxFee global
Summary

The -incrementalrelayfee option was removed from Bitcoin ABC in v0.17.2

This is a partial backport of core#25648
https://github.com/bitcoin/bitcoin/pull/25648/commits/fa9cba7afb73c01bd2c8fefd662dfc80dd98c5e8

Depends on D15752

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 21 2024, 16:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2024, 16:06
teamcity edited the summary of this revision. (Show Details)Mar 21 2024, 16:06
PiRK added a child revision: D15754: test: Remove unused cs_main.Mar 21 2024, 16:08
Harbormaster completed remote builds in B27971: Diff 46351.Mar 21 2024, 16:35
PiRK updated this revision to Diff 46384.Mar 22 2024, 16:02

rebase

PiRK published this revision for review.Mar 22 2024, 16:03
Harbormaster completed remote builds in B27993: Diff 46384.Mar 22 2024, 16:31
Fabien requested changes to this revision.Mar 25 2024, 09:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/policy/README.md
5 ↗(On Diff #46384)
src/node/interfaces.cpp
666 ↗(On Diff #46384)

It's never used ?

This revision now requires changes to proceed.Mar 25 2024, 09:50
PiRK added inline comments.Mar 25 2024, 11:32
src/node/interfaces.cpp
666 ↗(On Diff #46384)

It is used in the wallet code only (which does not have direct access to the mempool)

PiRK updated this revision to Diff 46442.Mar 25 2024, 11:32

improve policy/README.md

Harbormaster completed remote builds in B28043: Diff 46442.Mar 25 2024, 11:57
Fabien accepted this revision.Mar 25 2024, 12:56
This revision is now accepted and ready to land.Mar 25 2024, 12:56
Closed by commit rABC1f260dda7638: Remove ::minRelayTxFee global (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 25 2024, 13:44
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1f260dda7638: Remove ::minRelayTxFee global.

Revision Contents
Changeset List

PathSize
doc/
policy/
8 lines
src/
11 lines
kernel/
7 lines
14 lines
5 lines
node/
7 lines
policy/
4 lines
5 lines
1 line
rpc/
7 lines
7 lines
6 lines
5 lines
15 lines
wallet/
2 lines

Diff 46446

View Options

doc/policy/README.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/kernel/mempool_options.h

Loading...
View Options

src/mempool_args.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/interfaces.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/policy/settings.h

Loading...
View Options

src/policy/settings.cpp

Loading...
View Options

src/rpc/mempool.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/fees.cpp

Loading...