Page MenuHomePhabricator
Differential D15800

[e.cash] Tighten up wording on core-tech page
ClosedPublic
Actions

Authored by Mengerian on Mar 28 2024, 17:51.

Details

Reviewers
Fabien
bytesofman
Group Reviewers
Restricted Project
Commits
rABC35a1a454f13c: [e.cash] Tighten up wording on core-tech page
Summary

Remove obsolete and irrelevant portions

Test Plan

Ran it locally, looks fine

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-edit-core-tech
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28129
Build 55803: Build Diff
Build 55802: arc lint + arc unit

Event Timeline

Mengerian created this revision.Mar 28 2024, 17:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2024, 17:51
Mengerian requested review of this revision.Mar 28 2024, 17:51
Harbormaster completed remote builds in B28124: Diff 46551.Mar 28 2024, 17:51
bytesofman added a subscriber: bytesofman.Mar 28 2024, 19:54

@bot preview-e.cash

teamcity awarded a token.Mar 28 2024, 19:54

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41974 for the next 60 minutes.

Fabien accepted this revision.Mar 28 2024, 19:57
This revision is now accepted and ready to land.Mar 28 2024, 19:57
bytesofman requested changes to this revision.Mar 28 2024, 20:00
bytesofman added inline comments.
web/e.cash/pages/core-tech.js
61 ↗(On Diff #46551)

Imo worth removing all references to BCH

70–74 ↗(On Diff #46551)
This revision now requires changes to proceed.Mar 28 2024, 20:00
Mengerian updated this revision to Diff 46556.Mar 28 2024, 20:12

More extensive rewording per review:
Remove mention on Bitcoin Cash
Remove mention of governance

Harbormaster completed remote builds in B28129: Diff 46556.Mar 28 2024, 20:12
bytesofman requested changes to this revision.Mar 28 2024, 20:18
bytesofman added inline comments.
web/e.cash/pages/core-tech.js
61
73
This revision now requires changes to proceed.Mar 28 2024, 20:18
Mengerian updated this revision to Diff 46557.Mar 28 2024, 20:42
Mengerian edited the summary of this revision. (Show Details)

Avalanche proof of stake -> Avalanche

Harbormaster completed remote builds in B28130: Diff 46557.Mar 28 2024, 20:42
bytesofman accepted this revision.Mar 28 2024, 20:47
This revision is now accepted and ready to land.Mar 28 2024, 20:47
Closed by commit rABC35a1a454f13c: [e.cash] Tighten up wording on core-tech page (authored by Mengerian). · Explain WhyMar 28 2024, 20:48
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC35a1a454f13c: [e.cash] Tighten up wording on core-tech page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
18 lines

Diff 46556

View Options

web/e.cash/pages/core-tech.js

Loading...