Page MenuHomePhabricator
Differential D15857

Use value_type in CDataStream where possible
ClosedPublic
Actions

Authored by PiRK on Apr 2 2024, 15:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd88558168af1: Use value_type in CDataStream where possible
Summary

Also, simplify unit tests with the CDataStream::str method.

This is a partial backport of core#23451
https://github.com/bitcoin/bitcoin/pull/23451/commits/fabe18d0b39b4b918bf60e3a313eaa36fb4067f2

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 2 2024, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2024, 15:52
PiRK requested review of this revision.Apr 2 2024, 15:52
teamcity edited the summary of this revision. (Show Details)Apr 2 2024, 15:52
PiRK added inline comments.Apr 2 2024, 15:53
src/streams.h
288 ↗(On Diff #46737)

The change to this line in the source material is incorrect (see discussion in the review). In our codebase there is a test that caught the issue.

PiRK added a child revision: D15858: refactor: Use ignore helper when unserializing an invalid pubkey.Apr 2 2024, 15:54
PiRK added a comment.Apr 2 2024, 16:02

still working on an issue in the last commit of the PR, let's wait before reviewing this

PiRK planned changes to this revision.Apr 2 2024, 16:02
Harbormaster completed remote builds in B28267: Diff 46737.Apr 2 2024, 16:12
PiRK requested review of this revision.Apr 3 2024, 07:45
Fabien accepted this revision.Apr 4 2024, 07:41
This revision is now accepted and ready to land.Apr 4 2024, 07:41
Closed by commit rABCd88558168af1: Use value_type in CDataStream where possible (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 4 2024, 15:14
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd88558168af1: Use value_type in CDataStream where possible.

Revision Contents
Changeset List

PathSize
src/
18 lines
test/
6 lines

Diff 46835

View Options

src/streams.h

Loading...
View Options

src/test/streams_tests.cpp

Loading...