T2207
Depends on D15884
Move the Collapse-based wallet mgmt settings to their own screen. Rebuild it without antd.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC0c228103b7f3: [Cashtab] Move wallet mgmt to its own screen
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- manage-wallets-new-screen
- Lint
Lint Errors Severity Location Code Message Error cashtab/src/components/Wallets/__tests__/index.test.js:163 ESLINT jest/no-focused-tests Warning cashtab/src/components/Wallets/__tests__/index.test.js:215 ESLINT testing-library/no-debugging-utils - Unit
No Test Coverage - Build Status
Buildable 28385 Build 56312: Build Diff cashtab-tests Build 56311: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
Installing mock-chronik-client dependencies... /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 236 packages, and audited 237 packages in 1s 35 packages are looking for funding run `npm fund` for details found 0 vulnerabilities /work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 1718 packages, and audited 1719 packages in 29s 262 packages are looking for funding run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.21.1 build > node scripts/build.js Creating an optimized production build... Failed to compile. Attempted import error: 'isValidNewWalletNameLength' is not exported from 'validation' (imported as 'isValidNewWalletNameLength'). Build cashtab-tests failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
Installing mock-chronik-client dependencies... /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 236 packages, and audited 237 packages in 1s 35 packages are looking for funding run `npm fund` for details found 0 vulnerabilities /work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 1718 packages, and audited 1719 packages in 30s 262 packages are looking for funding run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.21.1 build > node scripts/build.js Creating an optimized production build... Failed to compile. Attempted import error: 'isValidNewWalletNameLength' is not exported from 'validation' (imported as 'isValidNewWalletNameLength'). Build cashtab-tests failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
vectors.js | 100 | 100 | 100 | 100 |
src/transactions | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/transactions/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/utils | 89.58 | 88.23 | 100 | 89.58 |
cashMethods.js | 100 | 100 | 100 | 100 |
formatting.js | 86.11 | 84.61 | 100 | 86.11 | 18,28,51-53
src/utils/fixtures | 0 | 0 | 0 | 0 |
vectors.js | 0 | 0 | 0 | 0 |
src/validation | 96.3 | 96.62 | 100 | 96.58 |
index.js | 96.3 | 96.62 | 100 | 96.58 | 178-179,321,353,373,420,618,714-715,849,854
src/validation/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/wallet | 94.36 | 85.79 | 83.67 | 94.82 |
context.js | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
useWallet.js | 91.69 | 79.33 | 74.19 | 92.36 | 66,150,423-429,468,538,609,636,658-666,706,738,769,775-778,852-853,878
src/wallet/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
---------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------------------
##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='3385']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='4229']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='1682']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2238']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='684']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='964']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='3334']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='4147']
##teamcity[blockClosed name='Code Coverage Summary']
Summary of all failing tests
FAIL src/components/Contacts/__tests__/index.test.js
● Test suite failed to run
Cannot find module 'components/Configure/fixtures/mocks' from 'src/components/Contacts/__tests__/index.test.js'
5 | import React from 'react';
6 | import { walletWithXecAndTokens } from 'components/App/fixtures/mocks';
> 7 | import { populatedContactList } from 'components/Configure/fixtures/mocks';
| ^
8 | import { render, screen, waitFor } from '@testing-library/react';
9 | import userEvent, {
10 | PointerEventsCheckLevel,
at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:427:11)
at Object.require (src/components/Contacts/__tests__/index.test.js:7:1)
Test Suites: 1 failed, 31 passed, 32 total
Tests: 741 passed, 741 total
Snapshots: 0 total
Time: 41.619 s
Ran all test suites.
Build cashtab-tests failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
vectors.js | 100 | 100 | 100 | 100 |
src/transactions | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/transactions/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/utils | 89.58 | 88.23 | 100 | 89.58 |
cashMethods.js | 100 | 100 | 100 | 100 |
formatting.js | 86.11 | 84.61 | 100 | 86.11 | 18,28,51-53
src/utils/fixtures | 0 | 0 | 0 | 0 |
vectors.js | 0 | 0 | 0 | 0 |
src/validation | 96.3 | 96.62 | 100 | 96.58 |
index.js | 96.3 | 96.62 | 100 | 96.58 | 178-179,321,353,373,420,618,714-715,849,854
src/validation/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/wallet | 94.36 | 85.79 | 83.67 | 94.82 |
context.js | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
useWallet.js | 91.69 | 79.33 | 74.19 | 92.36 | 66,150,423-429,468,538,609,636,658-666,706,738,769,775-778,852-853,878
src/wallet/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
---------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------------------
##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='3386']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='4230']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='1682']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2238']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='684']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='964']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='3335']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='4148']
##teamcity[blockClosed name='Code Coverage Summary']
Summary of all failing tests
FAIL src/components/Contacts/__tests__/index.test.js
● Test suite failed to run
Cannot find module 'components/Configure/fixtures/mocks' from 'src/components/Contacts/__tests__/index.test.js'
5 | import React from 'react';
6 | import { walletWithXecAndTokens } from 'components/App/fixtures/mocks';
> 7 | import { populatedContactList } from 'components/Configure/fixtures/mocks';
| ^
8 | import { render, screen, waitFor } from '@testing-library/react';
9 | import userEvent, {
10 | PointerEventsCheckLevel,
at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:427:11)
at Object.require (src/components/Contacts/__tests__/index.test.js:7:1)
Test Suites: 1 failed, 31 passed, 32 total
Tests: 741 passed, 741 total
Snapshots: 0 total
Time: 40.809 s
Ran all test suites.
Build cashtab-tests failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
vectors.js | 100 | 100 | 100 | 100 |
src/transactions | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
src/transactions/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/utils | 89.58 | 88.23 | 100 | 89.58 |
cashMethods.js | 100 | 100 | 100 | 100 |
formatting.js | 86.11 | 84.61 | 100 | 86.11 | 18,28,51-53
src/utils/fixtures | 0 | 0 | 0 | 0 |
vectors.js | 0 | 0 | 0 | 0 |
src/validation | 96.3 | 96.62 | 100 | 96.58 |
index.js | 96.3 | 96.62 | 100 | 96.58 | 178-179,321,353,373,420,618,714-715,849,854
src/validation/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/wallet | 94.36 | 85.79 | 83.67 | 94.82 |
context.js | 100 | 100 | 100 | 100 |
index.js | 100 | 100 | 100 | 100 |
useWallet.js | 91.69 | 79.33 | 74.19 | 92.36 | 66,150,423-429,468,538,609,636,658-666,706,738,769,775-778,852-853,878
src/wallet/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
---------------------------------|---------|----------|---------|---------|----------------------------------------------------------------------------------------------------------
##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='3389']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='4233']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='1684']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2240']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='685']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='965']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='3338']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='4151']
##teamcity[blockClosed name='Code Coverage Summary']
Summary of all failing tests
FAIL src/components/Contacts/__tests__/index.test.js
● Test suite failed to run
Cannot find module 'components/Configure/fixtures/mocks' from 'src/components/Contacts/__tests__/index.test.js'
5 | import React from 'react';
6 | import { walletWithXecAndTokens } from 'components/App/fixtures/mocks';
> 7 | import { populatedContactList } from 'components/Configure/fixtures/mocks';
| ^
8 | import { render, screen, waitFor } from '@testing-library/react';
9 | import userEvent, {
10 | PointerEventsCheckLevel,
at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:427:11)
at Object.require (src/components/Contacts/__tests__/index.test.js:7:1)
Test Suites: 1 failed, 31 passed, 32 total
Tests: 741 passed, 741 total
Snapshots: 0 total
Time: 40.808 s
Ran all test suites.
Build cashtab-tests failed with exit code 1| cashtab/src/components/App/__tests__/App.test.js | ||
|---|---|---|
| 501 ↗ | (On Diff #46921) | Move these tests to Configure as that is what they are testing |
| cashtab/src/components/App/fixtures/mocks.js | ||
| 2386 ↗ | (On Diff #46921) | this is now used by Contacts and Wallets, but not Configure, so keep it in App where it is common |
| cashtab/src/components/Common/CustomIcons.js | ||
| 11 ↗ | (On Diff #46921) | gotta stop with the antd icons but will be looking at this separately |
| cashtab/src/components/Configure/__tests__/Configure.test.js | ||
| 1 ↗ | (On Diff #46921) | In this file
|
| cashtab/src/validation/index.js | ||
| 448 ↗ | (On Diff #46921) | same as in Contacts improvement instead of trying to add a wallet that exists, failing, and throwing an error we validate before and disable the "ok" button if the name exists |
| cashtab/src/components/Wallets/index.js | ||
|---|---|---|
| 210 ↗ | (On Diff #46921) | It's not technically an issue arising out of this diff but we should either have a check here for unsupported 24 word seed mnemonics or just update the placeholder text on the modal to say "12 word mnemonic seed phrase"  Particularly as validateMnemonic only checks whether there are no words or contains invalid words. |
| 357 ↗ | (On Diff #46921) |  A few things here:
#activateButton{
border-radius: 15px;
border: 2px solid #73AD21;
padding: 10px;
width: 55px;
height: 20px;
}
 |
Comment Actions
rebase, better function for formatting wallet balances, better Activate button
| cashtab/src/components/Wallets/index.js | ||
|---|---|---|
| 210 ↗ | (On Diff #46921) | validateMnemonic is using bip39's validation method and ensuring we only support the englsh word list. Not sure on the > 12 word seed. We should add validation for this separately (maybe? I guess it's not the end of the world if someone really wants to import this). Good to note but imo not directly relevant to this diff. |
| 357 ↗ | (On Diff #46921) |
Will need to take care of the icons in general soon. imo this needs its own diff, as it impacts this and Contacts, and there is some scope to it.
Needs to be done, but for now I think it is ok to keep to current behavior as much as is practical.
yup this is ugly, updated
I added a better function to format wallet balance (and shorten the string as much as practical). As for the mouse hover over, I removed the tooltip and I think we should leave it that way. Mobile users cannot see this anyway, and imo we should make sure the UX supports mobile best first. Something that is desktop only should not be seen as a solution to a mobile ux problem. |