Page MenuHomePhabricator
Differential D1692

Use TxId in TransactionTableModel
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2018, 16:31.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd7699fb8422d: Use TxId in TransactionTableModel
rABCd7699fb8422d: Use TxId in TransactionTableModel
Summary

As per title.

Depends on D1691

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
transactionrecordtxid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3152
Build 4391: Bitcoin ABC Buildbot (legacy)
Build 4390: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2018, 16:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 16:31
teamcity added a subscriber: teamcity.Aug 26 2018, 16:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3150: Diff 4689.Aug 26 2018, 17:08
teamcity added a comment.Aug 26 2018, 17:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix updated this revision to Diff 4692.Aug 26 2018, 17:19

Also convert TransactionNotification

teamcity added a comment.Aug 26 2018, 17:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1694: Use TxId in TransactionRecord.Aug 26 2018, 17:21
Harbormaster failed remote builds in B3152: Diff 4692!Aug 26 2018, 17:56
teamcity added a comment.Aug 26 2018, 17:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox accepted this revision.Aug 27 2018, 05:59
This revision is now accepted and ready to land.Aug 27 2018, 05:59
teamcity added a comment.Aug 27 2018, 06:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 27 2018, 06:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3152: Diff 4692.Aug 27 2018, 06:38
deadalnix updated this revision to Diff 4705.Aug 27 2018, 14:14

rebase

teamcity added a comment.Aug 27 2018, 14:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 27 2018, 14:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3162: Diff 4705.Aug 27 2018, 14:53
Closed by commit rABCd7699fb8422d: Use TxId in TransactionTableModel (authored by deadalnix). · Explain WhySep 2 2018, 15:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
26 lines
wallet/
2 lines

Diff 4692

View Options

src/qt/transactiontablemodel.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...