Paths

Table of Contentst

Differential D15935

Use spans of std::byte in serialize
ClosedPublic
Actions

Authored by PiRK on Apr 10 2024, 15:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC16755cd2a145: Use spans of std::byte in serialize

Summary

This switches .read() and .write() to take spans of bytes.

This is a backport of core#23438
https://github.com/bitcoin/bitcoin/pull/23438/commits/fa24493d6394b3a477535f480664c9596f18e3c5

Depends ib D15934

Test Plan

ninja all check-all bitcoin-fuzzers bench-bitcoin

Run the seeder for a few minutes, make sure it finds nodes

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28476
Build 56493: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 56492: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 10 2024, 15:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2024, 15:05

PiRK requested review of this revision.Apr 10 2024, 15:05

Harbormaster completed remote builds in B28442: Diff 46991.Apr 10 2024, 15:05

PiRK edited the summary of this revision. (Show Details)Apr 10 2024, 15:06

PiRK edited the test plan for this revision. (Show Details)

PiRK added a child revision: D15936: Remove unused char serialize.Apr 10 2024, 15:14

teamcity edited the summary of this revision. (Show Details)Apr 10 2024, 21:11

rebase

Harbormaster completed remote builds in B28476: Diff 47030.Apr 11 2024, 07:41

Fabien accepted this revision.Apr 11 2024, 09:42

This revision is now accepted and ready to land.Apr 11 2024, 09:42

Closed by commit rABC16755cd2a145: Use spans of std::byte in serialize (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 11 2024, 10:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC16755cd2a145: Use spans of std::byte in serialize.

PiRK mentioned this in D15948: [chronik] fix ChronikBridge::load_raw_tx and compress_script.Apr 11 2024, 13:59

PiRK mentioned this in rABC7d5ff29ba399: [chronik] fix ChronikBridge::load_raw_tx and compress_script.Apr 11 2024, 14:52

Revision Contents
Changeset List

Path

Size

src/

bench/

checkblock.cpp

10 lines

rpc_blockchain.cpp

4 lines

common/

4 lines

10 lines

14 lines

4 lines

2 lines

4 lines

script/

bitcoinconsensus.cpp

12 lines

interpreter.cpp

4 lines

seeder/

bitcoin.cpp

6 lines

messagewriter.h

9 lines

test/

message_writer_tests.cpp

2 lines

util.h

6 lines

serialize.h

90 lines

streams.h

83 lines

support/

allocators/

zeroafterfree.h

3 lines

test/

bloom_tests.cpp

12 lines

fuzz/

16 lines

10 lines

8 lines

28 lines

48 lines

19 lines

6 lines

2 lines

wallet/

bdb.cpp

6 lines

sqlite.cpp

21 lines

Diff 47030

View Options

src/bench/checkblock.cpp

View Options

src/bench/rpc_blockchain.cpp

View Options

src/common/bloom.cpp

View Options

src/dbwrapper.h

View Options

src/hash.h

View Options

src/net.cpp

View Options

src/psbt.cpp

View Options

src/pubkey.h

View Options

src/script/bitcoinconsensus.cpp

View Options

src/script/interpreter.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/messagewriter.h

View Options

src/seeder/test/message_writer_tests.cpp

View Options

src/seeder/util.h

View Options

src/serialize.h

View Options

src/streams.h

View Options

src/support/allocators/zeroafterfree.h

View Options

src/test/bloom_tests.cpp

View Options

src/test/fuzz/autofile.cpp

View Options

src/test/fuzz/buffered_file.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/serialize_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/uint256.h

View Options

src/validation.cpp

View Options

src/wallet/bdb.cpp

View Options

Use spans of std::byte in serializeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47030

src/bench/checkblock.cpp

src/bench/rpc_blockchain.cpp

src/common/bloom.cpp

src/dbwrapper.h

src/hash.h

src/net.cpp

src/psbt.cpp

src/pubkey.h

src/script/bitcoinconsensus.cpp

src/script/interpreter.cpp

src/seeder/bitcoin.cpp

src/seeder/messagewriter.h

src/seeder/test/message_writer_tests.cpp

src/seeder/util.h

src/serialize.h

src/streams.h

src/support/allocators/zeroafterfree.h

src/test/bloom_tests.cpp

src/test/fuzz/autofile.cpp

src/test/fuzz/buffered_file.cpp

src/test/hash_tests.cpp

src/test/script_tests.cpp

src/test/serialize_tests.cpp

src/test/streams_tests.cpp

src/uint256.h

src/validation.cpp

src/wallet/bdb.cpp

src/wallet/sqlite.cpp

Use spans of std::byte in serialize
ClosedPublic
Actions

Revision Contents
Changeset List