Page MenuHomePhabricator
Differential D1689

Update ZapWallet to use TxId
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2018, 15:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2b9c738b022a: Update ZapWallet to use TxId
rABC2b9c738b022a: Update ZapWallet to use TxId
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ZapWalletTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3169
Build 4425: Bitcoin ABC Buildbot (legacy)
Build 4424: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2018, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 15:36
teamcity added a subscriber: teamcity.Aug 26 2018, 15:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 16:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3146: Diff 4683.Aug 26 2018, 16:11
deadalnix added a child revision: D1695: Use TxId in CWallet::mapTx.Aug 26 2018, 17:35
jasonbcox requested changes to this revision.Aug 27 2018, 05:43
jasonbcox added a subscriber: jasonbcox.

I think we can do better on the variable names to help move away from Hungarian notation.

src/wallet/rpcdump.cpp
410 ↗(On Diff #4683)

Since we're renaming this, let's use txIds to move towards a cleaner naming standard.

412 ↗(On Diff #4683)

txIdOuts

src/wallet/wallet.h
1010 ↗(On Diff #4683)

txIdOuts and txIdIns

src/wallet/walletdb.cpp
644 ↗(On Diff #4683)

txIds

748 ↗(On Diff #4683)

txIds

This revision now requires changes to proceed.Aug 27 2018, 05:43
deadalnix updated this revision to Diff 4707.Aug 27 2018, 14:15

rebase

teamcity added a comment.Aug 27 2018, 14:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 27 2018, 15:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3164: Diff 4707.Aug 27 2018, 15:08
deadalnix updated this revision to Diff 4716.Sep 2 2018, 16:34

Update names

teamcity added a comment.Sep 2 2018, 16:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Sep 2 2018, 16:36
This revision is now accepted and ready to land.Sep 2 2018, 16:36
teamcity added a comment.Sep 2 2018, 17:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3169: Diff 4716.Sep 2 2018, 17:10
Closed by commit rABC2b9c738b022a: Update ZapWallet to use TxId (authored by deadalnix). · Explain WhySep 2 2018, 17:36
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines
4 lines
10 lines
6 lines
44 lines

Diff 4716

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...