Page MenuHomePhabricator

Update ZapWallet to use TxId
ClosedPublic

Authored by deadalnix on Aug 26 2018, 15:36.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ZapWalletTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3169
Build 4425: Bitcoin ABC Buildbot (legacy)
Build 4424: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Aug 27 2018, 05:43
jasonbcox added a subscriber: jasonbcox.

I think we can do better on the variable names to help move away from Hungarian notation.

src/wallet/rpcdump.cpp
410 ↗(On Diff #4683)

Since we're renaming this, let's use txIds to move towards a cleaner naming standard.

412 ↗(On Diff #4683)

txIdOuts

src/wallet/wallet.h
1010 ↗(On Diff #4683)

txIdOuts and txIdIns

src/wallet/walletdb.cpp
644 ↗(On Diff #4683)

txIds

748 ↗(On Diff #4683)

txIds

This revision now requires changes to proceed.Aug 27 2018, 05:43
This revision is now accepted and ready to land.Sep 2 2018, 16:36
This revision was automatically updated to reflect the committed changes.