Page MenuHomePhabricator

[Cashtab] Better hamburger menu
ClosedPublic

Authored by bytesofman on Apr 16 2024, 18:45.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC5562be9e1887: [Cashtab] Better hamburger menu
Summary

We still want to migrate to horizontal scrolling nav buttons or mb a sidebar, but we are also still adding screens so it could be awhile.

In the meantime, the hamburger menu could use an update.

Make it bigger, get rid of empty space to the left of and between some buttons, use px instead of rem since we are not really font-size dependent for these dimensions, do not use float which does not work in display flex

Test Plan

npm test, npm start and aesthetic judgments

before

image.png (573×537 px, 60 KB)

after

image.png (573×537 px, 72 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hamburger-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28603
Build 56747: Build Diffcashtab-tests
Build 56746: arc lint + arc unit

Event Timeline

bytesofman edited the test plan for this revision. (Show Details)

Failed tests logs:

====== CashTab Unit Tests: <App /> Navigation menu routes to expected components ======
Error: expect(element).toHaveStyle()

- Expected

- max-height: 100rem;
+ max-height: 100vh;
    at Object.toHaveStyle (/work/cashtab/src/components/App/__tests__/App.test.js:262:54)

Each failure log is accessible here:
CashTab Unit Tests: <App /> Navigation menu routes to expected components

This revision is now accepted and ready to land.Apr 17 2024, 05:27
This revision was automatically updated to reflect the committed changes.