Page MenuHomePhabricator
Differential D1697

Use TxId in CWallet::IsLockedCoin
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2018, 17:47.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6208d0b4eeac: Use TxId in CWallet::IsLockedCoin
rABC6208d0b4eeac: Use TxId in CWallet::IsLockedCoin
Summary

As per title.

Depends on D1695

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txidwallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3170
Build 4427: Bitcoin ABC Buildbot (legacy)
Build 4426: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2018, 17:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 17:47
teamcity added a subscriber: teamcity.Aug 26 2018, 17:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix planned changes to this revision.Aug 26 2018, 18:13

This doesn't work.

teamcity added a comment.Aug 26 2018, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3156: Diff 4696!Aug 26 2018, 18:16
deadalnix updated this revision to Diff 4698.Aug 26 2018, 18:19

Fix various callsites.

teamcity added a comment.Aug 26 2018, 18:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3158: Diff 4698!Aug 26 2018, 18:56
teamcity added a comment.Aug 26 2018, 18:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix updated this revision to Diff 4722.Sep 3 2018, 12:44

Rebase and minor fix.

teamcity added a comment.Sep 3 2018, 12:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 3 2018, 13:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3170: Diff 4722.Sep 3 2018, 13:23
jasonbcox accepted this revision.Sep 4 2018, 16:03
This revision is now accepted and ready to land.Sep 4 2018, 16:03
Closed by commit rABC6208d0b4eeac: Use TxId in CWallet::IsLockedCoin (authored by deadalnix). · Explain WhySep 4 2018, 16:29
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
25 lines
2 lines
4 lines
wallet/
2 lines
4 lines

Diff 4722

View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...