Page MenuHomePhabricator
Differential D16012

[Cashtab] Searchable, alphabetical token list
ClosedPublic
Actions

Authored by bytesofman on Thu, Apr 18, 00:07.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC386a58e8cf46: [Cashtab] Searchable, alphabetical token list
Summary

Tokens are difficult to browse on the Token page. They are not searchable or in any kind of alphabetical order.

Improve this experience.

  • Sort user tokens alphabetically by ticker
  • Make tokens searchable by ticker or name, case-insensitive

Add a new integration test for <Etokens /> component to confirm expected behavior

Test Plan

npm test

this diff is live at https://cashtab-local-dev.netlify.app/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
searchable-token-list
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28650
Build 56841: Build Diffcashtab-tests
Build 56840: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Apr 18, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 18, 00:07
Harbormaster completed remote builds in B28640: Diff 47261.Thu, Apr 18, 00:10
bytesofman updated this revision to Diff 47274.Thu, Apr 18, 21:50

working

bytesofman edited the summary of this revision. (Show Details)Thu, Apr 18, 21:52
bytesofman updated this revision to Diff 47275.Thu, Apr 18, 21:53

back out unrelated changes

Harbormaster completed remote builds in B28647: Diff 47274.Thu, Apr 18, 21:53
Harbormaster completed remote builds in B28648: Diff 47275.Thu, Apr 18, 21:56
bytesofman updated this revision to Diff 47276.Thu, Apr 18, 22:27

add integration test

Harbormaster completed remote builds in B28649: Diff 47276.Thu, Apr 18, 22:27
bytesofman updated this revision to Diff 47277.Thu, Apr 18, 22:28

lint

Harbormaster completed remote builds in B28650: Diff 47277.Thu, Apr 18, 22:31
bytesofman updated this revision to Diff 47278.Thu, Apr 18, 22:31

remove debug comments

bytesofman updated this revision to Diff 47279.Thu, Apr 18, 22:32

minor version bump + extension

Harbormaster completed remote builds in B28651: Diff 47278.Thu, Apr 18, 22:34
Harbormaster completed remote builds in B28652: Diff 47279.
bytesofman published this revision for review.Thu, Apr 18, 22:37
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
emack accepted this revision.Fri, Apr 19, 08:42
This revision is now accepted and ready to land.Fri, Apr 19, 08:42
Closed by commit rABC386a58e8cf46: [Cashtab] Searchable, alphabetical token list (authored by bytesofman). · Explain WhyFri, Apr 19, 09:18
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC386a58e8cf46: [Cashtab] Searchable, alphabetical token list.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Etokens/
95 lines
15 lines
23 lines
__tests__/
161 lines
fixtures/
5943 lines

Diff 47277

View Options

cashtab/src/components/Etokens/Etokens.js

Loading...
View Options

cashtab/src/components/Etokens/TokenList.js

Loading...
View Options

cashtab/src/components/Etokens/TokenListItem.js

Loading...
View Options

cashtab/src/components/Etokens/__tests__/Etokens.test.js

Loading...
View Options

cashtab/src/components/Etokens/fixtures/mocks.js

Loading...