[avalanche] Remove finalized txs upon block finalization
ClosedPublic
Actions

Authored by Fabien on Apr 19 2024, 10:18.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf47d323192d1: [avalanche] Remove finalized txs upon block finalization

Summary

Make sure the txs remain finalized after a block is mined.
Note that we still need to remove the txs from the radix tree if another
event (not a block) is causing the mempool removal.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avlanche_remove_finalized_tx_upon_block_finalization

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28660
Build 56861: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 56860: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 19 2024, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2024, 10:18

Fabien requested review of this revision.Apr 19 2024, 10:18

Harbormaster completed remote builds in B28660: Diff 47299.Apr 19 2024, 10:57

PiRK added a subscriber: PiRK.Apr 19 2024, 14:42

PiRK added inline comments.

src/net_processing.cpp
6257	TIL `!"string"` I'm not sure this adds much info vs a simple `assert(ReadBlockFromDisk(...))` Assertion `!"cannot load block from disk"' failed. vs Assertion `ReadBlockFromDisk()' failed.