[Cashtab] Stop notifying on every avalanche finalized block
ClosedPublic
Actions

Authored by bytesofman on Apr 21 2024, 13:54.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC2b167fb4f76a: [Cashtab] Stop notifying on every avalanche finalized block

Summary

T3557

With the next halving a bit far away, these notifications are overkill.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

silence-block-notifications

Lint

Lint Errors

Severity	Location	Code	Message
Error	cashtab/src/wallet/useWallet.js:45	ESLINT	no-unused-vars
Error	cashtab/src/wallet/useWallet.js:46	ESLINT	no-unused-vars
Error	cashtab/src/wallet/useWallet.js:47	ESLINT	no-unused-vars
Error	cashtab/src/wallet/useWallet.js:49	ESLINT	no-unused-vars

Unit

No Test Coverage

Build Status

Buildable 28702
Build 56945: Build Diff	cashtab-tests
Build 56944: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 21 2024, 13:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2024, 13:54

Harbormaster completed remote builds in B28702: Diff 47358.Apr 21 2024, 13:54

lint

bytesofman published this revision for review.Apr 21 2024, 13:55

bytesofman edited the summary of this revision. (Show Details)

bytesofman added inline comments.

cashtab/src/wallet/useWallet.js
566 ↗	(On Diff #47359)	we still update the chaintip when these blocks are found, which is used for the "finalized" check animation in tx history

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Installing mock-chronik-client dependencies...
/work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 236 packages, and audited 237 packages in 2s

35 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
/work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 1656 packages, and audited 1657 packages in 29s

261 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@2.35.2 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/wallet/useWallet.js
  Line 45:5:   'BlockNotification' is defined but never used      no-unused-vars
  Line 46:5:   'BlockNotificationLink' is defined but never used  no-unused-vars
  Line 47:5:   'BlockNotificationDesc' is defined but never used  no-unused-vars
  Line 49:10:  'explorer' is defined but never used               no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Harbormaster completed remote builds in B28703: Diff 47359.Apr 21 2024, 14:14

emack accepted this revision.Apr 21 2024, 14:40

This revision is now accepted and ready to land.Apr 21 2024, 14:40

Closed by commit rABC2b167fb4f76a: [Cashtab] Stop notifying on every avalanche finalized block (authored by bytesofman). · Explain WhyApr 21 2024, 14:57

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC2b167fb4f76a: [Cashtab] Stop notifying on every avalanche finalized block.