Page MenuHomePhabricator
Differential D1715

Variosu nits in walletmodel.{h|cpp}
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 17:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5cd1c2b81fa3: Variosu nits in walletmodel.{h|cpp}
rABC5cd1c2b81fa3: Variosu nits in walletmodel.{h|cpp}
Summary

As per title

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletmodelnit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3186
Build 4459: Bitcoin ABC Buildbot (legacy)
Build 4458: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 17:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 17:19
teamcity added a subscriber: teamcity.Sep 4 2018, 17:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Sep 4 2018, 17:28
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/walletmodel.h
299 ↗(On Diff #4746)

Single line comments should be // style I thought?

This revision now requires changes to proceed.Sep 4 2018, 17:28
deadalnix added inline comments.Sep 4 2018, 17:44
src/qt/walletmodel.h
299 ↗(On Diff #4746)

These are doc comment.

deadalnix requested review of this revision.Sep 4 2018, 17:44
deadalnix updated this revision to Diff 4752.Sep 4 2018, 17:52

rebase

teamcity added a comment.Sep 4 2018, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3185: Diff 4746.Sep 4 2018, 17:54
teamcity added a comment.Sep 4 2018, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 18:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3186: Diff 4752!Sep 4 2018, 18:49
jasonbcox accepted this revision.Sep 4 2018, 21:25
jasonbcox added inline comments.
src/qt/walletmodel.h
299 ↗(On Diff #4746)

I see.

This revision is now accepted and ready to land.Sep 4 2018, 21:25
deadalnix updated this revision to Diff 4767.Sep 5 2018, 10:52

rebase

teamcity added a comment.Sep 5 2018, 10:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 5 2018, 11:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3197: Diff 4767!Sep 5 2018, 11:31
Closed by commit rABC5cd1c2b81fa3: Variosu nits in walletmodel.{h|cpp} (authored by deadalnix). · Explain WhySep 5 2018, 12:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
22 lines
58 lines

Diff 4752

View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...