Page MenuHomePhabricator

Variosu nits in walletmodel.{h|cpp}
ClosedPublic

Authored by deadalnix on Sep 4 2018, 17:19.

Details

Summary

As per title

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletmodelnit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3186
Build 4459: Bitcoin ABC Buildbot (legacy)
Build 4458: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Sep 4 2018, 17:28
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/walletmodel.h
299 ↗(On Diff #4746)

Single line comments should be // style I thought?

This revision now requires changes to proceed.Sep 4 2018, 17:28
src/qt/walletmodel.h
299 ↗(On Diff #4746)

These are doc comment.

jasonbcox added inline comments.
src/qt/walletmodel.h
299 ↗(On Diff #4746)

I see.

This revision is now accepted and ready to land.Sep 4 2018, 21:25
This revision was automatically updated to reflect the committed changes.