Page MenuHomePhabricator
Differential D16126

[ecash-lib] Dockerfile for CI publication to npm
ClosedPublic
Actions

Authored by bytesofman on May 7 2024, 22:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf2211316c9fa: [ecash-lib] Dockerfile for CI publication to npm
Summary

Add a top-level Dockerfile to build and deploy ecash-lib to npm on version bumps

Test Plan

docker build -f ecash-lib.Dockerfile -t ecash-lib_local .

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-lib-ci-top-level
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28933
Build 57403: Build Diff
Build 57402: arc lint + arc unit

Event Timeline

bytesofman created this revision.May 7 2024, 22:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2024, 22:55
Harbormaster completed remote builds in B28933: Diff 47672.May 7 2024, 22:55
bytesofman published this revision for review.May 7 2024, 22:56
Fabien requested changes to this revision.May 8 2024, 08:12
Fabien added a subscriber: Fabien.

file looks good except for the hash check which is useless

ecash-lib.Dockerfile
23

Checking at this stage is not helpful. This doesn't give any confidence to the end user that the binary file is correct, because the user only ever deal with the output of this build.

This revision now requires changes to proceed.May 8 2024, 08:12
bytesofman updated this revision to Diff 47681.May 8 2024, 12:18
bytesofman marked an inline comment as done.

remove checksum

Harbormaster completed remote builds in B28939: Diff 47681.May 8 2024, 12:18
bytesofman updated this revision to Diff 47682.May 8 2024, 12:18

improve comment order

Harbormaster completed remote builds in B28940: Diff 47682.May 8 2024, 12:18
Fabien accepted this revision.May 8 2024, 13:09
This revision is now accepted and ready to land.May 8 2024, 13:09
Closed by commit rABCf2211316c9fa: [ecash-lib] Dockerfile for CI publication to npm (authored by bytesofman). · Explain WhyMay 8 2024, 13:17
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf2211316c9fa: [ecash-lib] Dockerfile for CI publication to npm.

Revision Contents
Changeset List

PathSize
31 lines

Diff 47672

View Options

ecash-lib.Dockerfile

Loading...