Paths

Table of Contentst

Differential D16151

refactor: Extract util/fs_helpers from util/system
ClosedPublic
Actions

Authored by PiRK on May 13 2024, 16:46.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0d0aa0ec5fa8: refactor: Extract util/fs_helpers from util/system

Summary

This is an extraction of filesystem related functions from util/system
into their own utility file.

The background of this commit is an ongoing effort to decouple the
libbitcoinkernel library from the ArgsManager defined in system.h.
Moving these functions out of system.h allows including them from a
separate source file without including the ArgsManager definitions from
system.h.

This is a partial backport of core#27254
https://github.com/bitcoin/bitcoin/pull/27254/commits/18fb36367a28819bd5ab402344802796a1248979

Depends on D16150

Test Plan

With DBUILD_BITCOIN_CHAINSTATE:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr26140

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28989
Build 57515: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57514: arc lint + arc unit

Event Timeline

PiRK created this revision.May 13 2024, 16:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2024, 16:46

PiRK requested review of this revision.May 13 2024, 16:46

teamcity edited the summary of this revision. (Show Details)May 13 2024, 16:46

Harbormaster completed remote builds in B28989: Diff 47746.May 13 2024, 17:22

PiRK added a child revision: D16152: misc fixes for file syncing.May 14 2024, 07:51

Fabien accepted this revision.May 14 2024, 08:09

This revision is now accepted and ready to land.May 14 2024, 08:09

Closed by commit rABC0d0aa0ec5fa8: refactor: Extract util/fs_helpers from util/system (authored by Ben Woosley <ben.woosley@gmail.com>, committed by PiRK). · Explain WhyMay 14 2024, 10:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0d0aa0ec5fa8: refactor: Extract util/fs_helpers from util/system.

PiRK mentioned this in D16207: kernel: Add warning method to notifications.May 23 2024, 09:19

PiRK mentioned this in rABCfa9a010420d1: kernel: Add warning method to notifications.May 23 2024, 19:12

Revision Contents
Changeset List

Path

Size

src/

2 lines

1 line

avalanche/

peermanager.cpp

1 line

test/

peermanager_tests.cpp

1 line

1 line

2 lines

index/

blockfilterindex.cpp

1 line

1 line

init/

1 line

kernel/

mempool_persist.cpp

2 lines

qt/

1 line

1 line

walletframe.cpp

2 lines

1 line

rpc/

1 line

test/

2 lines

3 lines

util/

52 lines

291 lines

34 lines

259 lines

2 lines

wallet/

1 line

rpc/

1 line

2 lines

1 line

Diff 47746

src/CMakeLists.txt

Loading...

src/addrdb.cpp

Loading...

src/avalanche/peermanager.cpp

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...

src/dbwrapper.cpp

Loading...

src/flatfile.cpp

Loading...

src/index/blockfilterindex.cpp

Loading...

src/init.cpp

Loading...

src/init/common.cpp

Loading...

src/kernel/mempool_persist.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/intro.cpp

Loading...

src/qt/walletframe.cpp

Loading...

src/qt/walletview.cpp

Loading...

src/rpc/request.cpp

Loading...

src/test/fs_tests.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/util/fs_helpers.h

Loading...

src/util/fs_helpers.cpp

Loading...

src/util/system.h

Loading...

src/util/system.cpp

Loading...

src/validation.cpp

Loading...

src/wallet/bdb.cpp

Loading...

src/wallet/rpc/backup.cpp

Loading...

src/wallet/sqlite.cpp

Loading...

src/wallet/wallet.cpp

Loading...