refactor: Use move semantics in `CCheckQueue::Loop`
ClosedPublic
Actions

Authored by PiRK on May 13 2024, 06:52.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC600ecb007d3a: refactor: Use move semantics in `CCheckQueue::Loop`

Summary

refactor: Use move semantics in CCheckQueue::Loop

Co-authored-by: Martin Leitner-Ankerl <martin.ankerl@gmail.com>

https://github.com/bitcoin/bitcoin/pull/26749/commits/d8427cc28e3a9ac3319fb452b16661957c812b8f

Drop no longer used CScriptCheck() default constructor

https://github.com/bitcoin/bitcoin/pull/26749/commits/b4bed5c1f98c0eed18f52fdcea11a420c10ed98d

This is a partial backport of core#26479
Depends on D16144

Test Plan

ninja all check bitcoin-fuzzers bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 13 2024, 06:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2024, 06:52

PiRK requested review of this revision.May 13 2024, 06:52

teamcity edited the summary of this revision. (Show Details)May 13 2024, 06:52

PiRK added a child revision: D16146: refactor: Drop no longer used `swap` member functions.May 13 2024, 06:53

Harbormaster completed remote builds in B28983: Diff 47740.May 13 2024, 07:41

@bot build-asan

teamcity awarded a token.May 13 2024, 13:59

Fabien accepted this revision.May 13 2024, 14:17

This revision is now accepted and ready to land.May 13 2024, 14:17

Closed by commit rABC600ecb007d3a: refactor: Use move semantics in `CCheckQueue::Loop` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 13 2024, 16:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC600ecb007d3a: refactor: Use move semantics in `CCheckQueue::Loop`.

Revision Contents
Changeset List

Path

Size

src/

bench/

checkqueue.cpp

2 lines

checkqueue.h

12 lines

test/

fuzz/

checkqueue.cpp

4 lines

validation.h

5 lines

Diff 47749

View Options

src/bench/checkqueue.cpp

View Options

src/checkqueue.h

View Options

src/test/fuzz/checkqueue.cpp

View Options

refactor: Use move semantics in `CCheckQueue::Loop`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47749

src/bench/checkqueue.cpp

src/checkqueue.h

src/test/fuzz/checkqueue.cpp

src/validation.h

refactor: Use move semantics in `CCheckQueue::Loop`
ClosedPublic
Actions

Revision Contents
Changeset List