refactor: Declare g_zmq_notification_interface as unique_ptr
ClosedPublic
Actions

Authored by PiRK on May 20 2024, 09:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1b5e4c74d4d5: refactor: Declare g_zmq_notification_interface as unique_ptr

Summary

Ensures better memory safety for this global. This came up during
discussion of the following commit, but is not strictly required for its
implementation.

This is a partial backport of core#27125
https://github.com/bitcoin/bitcoin/pull/27125/commits/8ed4ff8e05d61a8e954d72cebdc2e1d1ab24fb84

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29037
Build 57610: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-clang · build-clang-tidy · build-diff
Build 57609: arc lint + arc unit

Event Timeline

PiRK created this revision.May 20 2024, 09:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2024, 09:43

PiRK requested review of this revision.May 20 2024, 09:43

teamcity edited the summary of this revision. (Show Details)May 20 2024, 09:43

PiRK added a child revision: D16183: zmq: Pass lambda to zmq's ZMQPublishRawBlockNotifier.May 20 2024, 09:45

Harbormaster completed remote builds in B29037: Diff 47828.May 20 2024, 10:06

Fabien accepted this revision.May 20 2024, 11:12

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/zmq/zmqnotificationinterface.cpp
59	While you're at it, it can use make_unique: auto notificationInterface = std::make_unique<CZMQNotificationInterface>();

This revision is now accepted and ready to land.May 20 2024, 11:12

src/zmq/zmqnotificationinterface.cpp
59	It does not work because the constructor is private. /usr/include/c++/11/bits/unique_ptr.h:962:30: error: ‘CZMQNotificationInterface::CZMQNotificationInterface()’ is private within this context It is a bit weird, the `Create` member function can access the private constructor from the same class, but not when the ctor call is wrapped in a `std::make_unique` call.