Page MenuHomePhabricator

fix check-crates target
ClosedPublic

Authored by PiRK on May 21 2024, 07:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3db48ecde096: fix check-crates target
Summary

Use single quotes around --package patterns to avoid glob expansion.
This fixes the error

[Step 1/1] FAILED: chronik/CMakeFiles/check-crate-chronik-test
[Step 1/1] cd /work && /usr/bin/cmake -E env CARGO_TARGET_DIR="/work/abc-ci-builds/build-chronik-plugins/cargo/build" CARGO_BUILD_RUSTC="/root/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/rustc" CARGO_BUILD_RUSTDOC="/root/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/rustdoc" /root/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/cargo --locked test --package chronik-*
[Step 1/1] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
[Step 1/1] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
[Step 1/1] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
[Step 1/1] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
[Step 1/1] error: invalid character `.` in package name: `chronik-client.Dockerfile`, characters must be Unicode XID characters (numbers, `-`, `_`, or most letters)
Test Plan

ninja check-crates

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable