Don't use a PeerManager for the net group limit test
ClosedPublic
Actions

Authored by Fabien on May 21 2024, 20:10.

Details

Reviewers

bytesofman
PiRK

Group Reviewers

Restricted Project

Commits

rABCe5dabdb0689a: Don't use a PeerManager for the net group limit test

Summary

This is simply unused, we can just stick to the test suite fixture.

Test Plan

ninja check-bitcoin-net_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_net_tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29061
Build 57658: Build Diff	lint-circular-dependencies · build-debug · build-clang · build-without-wallet · build-diff · build-clang-tidy
Build 57657: arc lint + arc unit

Event Timeline

Fabien created this revision.May 21 2024, 20:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2024, 20:10

Fabien requested review of this revision.May 21 2024, 20:10

Harbormaster completed remote builds in B29061: Diff 47868.May 21 2024, 20:26

bytesofman accepted this revision.May 21 2024, 23:49

This revision is now accepted and ready to land.May 21 2024, 23:49

PiRK accepted this revision.May 22 2024, 05:47

Closed by commit rABCe5dabdb0689a: Don't use a PeerManager for the net group limit test (authored by Fabien). · Explain WhyMay 22 2024, 06:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe5dabdb0689a: Don't use a PeerManager for the net group limit test.

Revision Contents
Changeset List

Path

Size

src/

test/

net_tests.cpp

5 lines

Diff 47868

View Options

Don't use a PeerManager for the net group limit testClosedPublicActions