kernel: Add progress method to notifications
ClosedPublic
Actions

Authored by PiRK on May 23 2024, 09:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc2307765fd61: kernel: Add progress method to notifications

Summary

This commit is part of the libbitcoinkernel project and seeks to remove
the ChainstateManager's and, more generally, the kernel library's
dependency on interface_ui with options methods in this and the
following few commits. By removing interface_ui from the kernel library,
its dependency on boost is reduced to just boost::multi_index.

This is a partial backport of core#27636
https://github.com/bitcoin/bitcoin/pull/27636/commits/4452707edec91c7d7991f486dd41ef3edb4f7fbf
Depends on D16205

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29110
Build 57756: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57755: arc lint + arc unit

Event Timeline

PiRK created this revision.May 23 2024, 09:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2024, 09:18

PiRK requested review of this revision.May 23 2024, 09:18

teamcity edited the summary of this revision. (Show Details)May 23 2024, 09:18

PiRK added a child revision: D16207: kernel: Add warning method to notifications.May 23 2024, 09:19

Harbormaster completed remote builds in B29102: Diff 47920.May 23 2024, 10:03

Fabien requested changes to this revision.May 23 2024, 13:45

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/bitcoin-chainstate.cpp
39 ↗	(On Diff #47920)	that seems wrong, bilingual_str is not defined in <string>
src/kernel/notifications_interface.h
9 ↗	(On Diff #47920)	same here, seems unnecessary
src/node/kernel_notifications.cpp
8 ↗	(On Diff #47920)	that's the right one
src/node/kernel_notifications.h
11 ↗	(On Diff #47920)	dito