Page MenuHomePhabricator
Differential D1731

Move RPC global strings to globals.h/cpp and access them through config
ClosedPublic
Actions

Authored by jasonbcox on Sep 6 2018, 15:40.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING6995b845cb86: Move RPC global strings to globals.h/cpp and access them through config
rABC6995b845cb86: Move RPC global strings to globals.h/cpp and access them through config
Summary

Prep for T401. Completes T329.

Test Plan

make check && test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpcglobals
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3217
Build 4521: Bitcoin ABC Buildbot (legacy)
Build 4520: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 6 2018, 15:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2018, 15:40
teamcity added a subscriber: teamcity.Sep 6 2018, 15:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Sep 6 2018, 15:45
deadalnix added inline comments.
src/httprpc.cpp
11 ↗(On Diff #4794)

No. Access it through globalconfig

This revision now requires changes to proceed.Sep 6 2018, 15:45
teamcity added a comment.Sep 6 2018, 16:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3216: Diff 4794.Sep 6 2018, 16:16
jasonbcox updated this revision to Diff 4795.Sep 6 2018, 16:20

Added config accessors

teamcity added a comment.Sep 6 2018, 16:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox retitled this revision from Move RPC global strings to globals.h/cpp to Move RPC global strings to globals.h/cpp and access them through config.Sep 6 2018, 16:21
jasonbcox edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Sep 6 2018, 16:30
This revision is now accepted and ready to land.Sep 6 2018, 16:30
teamcity added a comment.Sep 6 2018, 16:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3217: Diff 4795.Sep 6 2018, 16:56
Closed by commit rABC6995b845cb86: Move RPC global strings to globals.h/cpp and access them through config (authored by jasonbcox). · Explain WhySep 6 2018, 19:04
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
15 lines
16 lines
9 lines
3 lines
3 lines
34 lines
2 lines

Diff 4795

View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/globals.h

Loading...
View Options

src/globals.cpp

Loading...
View Options

src/httprpc.h

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/init.cpp

Loading...