Differential D16395

package validation quits early due to non-policy, non-missing-inputs failure
ClosedPublic
Actions

Authored by Fabien on Jul 1 2024, 21:03.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC1796fad75bd4: package validation quits early due to non-policy, non-missing-inputs failure

Summary

Partial backport of core#26646:
https://github.com/bitcoin/bitcoin/pull/26646/commits/be2e4d94e59510e0a98408313feb27e97321b16e
https://github.com/bitcoin/bitcoin/pull/26646/commits/5d35b4a7dee95ae70bfdcbe79bc39fe488641b23

The test is massaged to work with our coinbase.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR26646_1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29423
Build 58382: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58381: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 1 2024, 21:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2024, 21:03

Fabien requested review of this revision.Jul 1 2024, 21:03

teamcity edited the summary of this revision. (Show Details)Jul 1 2024, 21:03

Fabien added a child revision: D16396: [validation] return effective feerate from mempool validation.Jul 1 2024, 21:04

Rebase

roqqit accepted this revision.Jul 1 2024, 21:40

This revision is now accepted and ready to land.Jul 1 2024, 21:40

Harbormaster completed remote builds in B29423: Diff 48429.Jul 1 2024, 22:12

Harbormaster completed remote builds in B29429: Diff 48435.Jul 1 2024, 23:05

Closed by commit rABC1796fad75bd4: package validation quits early due to non-policy, non-missing-inputs failure (authored by glozow <gloriajzhao@gmail.com>, committed by Fabien). · Explain WhyJul 2 2024, 07:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1796fad75bd4: package validation quits early due to non-policy, non-missing-inputs failure.

Revision Contents
Changeset List

Path

Size

src/

test/

txpackage_tests.cpp

35 lines

validation.cpp

27 lines

Diff 48429

View Options

src/test/txpackage_tests.cpp