Differential D16399

[rpc] return effective-includes in testmempoolaccept and submitpackage
ClosedPublic
Actions

Authored by Fabien on Jul 1 2024, 21:06.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC767729f0bef1: [rpc] return effective-includes in testmempoolaccept and submitpackage

Summary

Partial backport of core#26646:
https://github.com/bitcoin/bitcoin/pull/26646/commits/601bac88cb95404e7d38ac6348d959c0e06bd922

Depends on D16398.

Using TxId instead of WTxId.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 1 2024, 21:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2024, 21:06

Fabien requested review of this revision.Jul 1 2024, 21:06

teamcity edited the summary of this revision. (Show Details)Jul 1 2024, 21:06

Fabien added a child revision: D16400: [validation] remove PackageMempoolAcceptResult::m_package_feerate.Jul 1 2024, 21:07

Rebase

Harbormaster completed remote builds in B29427: Diff 48433.Jul 1 2024, 22:46

Not blocking on this feedback but the keys should ideally be the same and the help text should match

src/rpc/mempool.cpp
175 ↗	(On Diff #48439)	Result key is "size" in ABC
837 ↗	(On Diff #48439)	Strange that the key is actually "vsize" for submitpackage

This revision is now accepted and ready to land.Jul 1 2024, 23:10

Harbormaster completed remote builds in B29433: Diff 48439.Jul 1 2024, 23:44

Fabien added inline comments.Jul 2 2024, 07:18

src/rpc/mempool.cpp
175 ↗	(On Diff #48439)	Yes this is something that needs to be fixed, but here vsize is correct. The mempool minimal fee policy is based on vsize (size + sigchecks) while the relay policy is only based on size. The RPCs are also all over the place (see comment: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/rpc_packages.py$404) I will leave it as-is as the doc is correct, despite the RPC returning size.
837 ↗	(On Diff #48439)	Same issue as above

Closed by commit rABC767729f0bef1: [rpc] return effective-includes in testmempoolaccept and submitpackage (authored by glozow <gloriajzhao@gmail.com>, committed by Fabien). · Explain WhyJul 2 2024, 07:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC767729f0bef1: [rpc] return effective-includes in testmempoolaccept and submitpackage.

Revision Contents
Changeset List

Path

Size

src/

rpc/

30 lines

test/

functional/

mempool_accept.py

1 line

rpc_packages.py

12 lines

Diff 48448

src/rpc/mempool.cpp

Loading...

test/functional/mempool_accept.py

Loading...

test/functional/rpc_packages.py

Loading...