Page MenuHomePhabricator

[rpc] return effective-includes in testmempoolaccept and submitpackage
ClosedPublic

Authored by Fabien on Jul 1 2024, 21:06.

Details

Summary
Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jul 1 2024, 21:06
roqqit added a subscriber: roqqit.

Not blocking on this feedback but the keys should ideally be the same and the help text should match

src/rpc/mempool.cpp
175 ↗(On Diff #48439)

Result key is "size" in ABC

837 ↗(On Diff #48439)

Strange that the key is actually "vsize" for submitpackage

This revision is now accepted and ready to land.Jul 1 2024, 23:10
src/rpc/mempool.cpp
175 ↗(On Diff #48439)

Yes this is something that needs to be fixed, but here vsize is correct.
The mempool minimal fee policy is based on vsize (size + sigchecks) while the relay policy is only based on size. The RPCs are also all over the place (see comment: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/rpc_packages.py$404)

I will leave it as-is as the doc is correct, despite the RPC returning size.

837 ↗(On Diff #48439)

Same issue as above